ci: enforce complete Python type checking - #675
Draft
afourniernv wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Alex Fournier <afournier@nvidia.com>
Contributor
Author
|
For clarity, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes CI type-check both shipped Python packages and treats mypy failures as blocking.
The workflow now uses the roots already configured in
pyproject.tomlinstead of overriding them with onlyswitchyard.Why
The mypy configuration includes both
switchyardandswitchyard_rust, but CI currently passesswitchyardexplicitly and leaves the Rust binding facade unchecked. The job also usescontinue-on-error, so type errors do not block a PR.Both packages already pass under the existing strict configuration.
How tested
uv sync --lockeduv run mypy— no issues in 7 source filesswitchyard_rust, confirmed mypy failed, removed it, and confirmed mypy passed againuv run ruff check .uv run pytest tests/ -v -m "not integration"— 117 passed, 2 deselectedNo runtime behavior, public APIs, dependencies, packaging, or release behavior change.