ci: bound package portability runs - #674
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. WalkthroughThe package portability workflow now cancels superseded pull-request runs. Push and manual runs remain independent. The wheel job has a 30-minute timeout. ChangesPackage portability workflow
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The workflow now cancels superseded pull-request runs, keeps push and manual runs independent, and caps wheel jobs at 30 minutes. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
A rabbit watches wheels roll bright Comment |
Signed-off-by: Alex Fournier <afournier@nvidia.com>
37bb6a2 to
15b0d89
Compare
|
Relay has precedent for both pieces:
This PR keeps the policy narrower for Switchyard: only superseded PR runs are canceled, main and manual runs get unique groups, and the timeout applies only to the existing x86_64 wheel job. |
ayushag-nv
left a comment
There was a problem hiding this comment.
looks good. Nice addition
What
mainpushes and manual runs independent.Why
The portability job currently keeps running after a pull request receives a newer commit. Those outdated wheel builds overlap with the current run and use the same CI capacity.
The concurrency key is shared only by runs for the same pull request. Push and manual runs use their unique run ID, so they are not serialized or dropped.
Recent successful wheel jobs take about four minutes, with a maximum of roughly four minutes and 20 seconds across the latest 100 runs. Thirty minutes leaves substantial headroom while avoiding GitHub's six-hour default if the build hangs.
How tested
actionlint .github/workflows/package-portability.ymlgit diff --checkNotes for reviewers
This changes only workflow run control. The package matrix, build commands, release workflow, artifacts, and publishing behavior are unchanged.
The timeout applies after a runner starts the job. It does not affect time spent waiting for a runner or approval.