Skip to content

ci: skip project builds for static checks - #673

Merged
bhuvan002 merged 1 commit into
mainfrom
codex/ci-skip-project-builds
Sep 10, 2026
Merged

ci: skip project builds for static checks#673
bhuvan002 merged 1 commit into
mainfrom
codex/ci-skip-project-builds

Conversation

@afourniernv

@afourniernv afourniernv commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What

Updates the Ruff and mypy jobs to install the locked development dependencies without installing the local Switchyard project. Both tools then run without synchronizing the environment a second time.

Why

Ruff and mypy inspect the source tree and do not need the installed Switchyard package. The existing setup builds the local Maturin/PyO3 project before each check. In a clean local control run with dependencies cached, that build took about two minutes.

--no-install-project skips the local project while retaining its dependencies. --no-sync prevents uv run from synchronizing again and installing the project anyway. Relay uses the same pairing.

How tested

  • UV_PYTHON=3.12 uv sync --locked --no-install-project
  • UV_PYTHON=3.12 uv run --no-sync ruff check .
  • UV_PYTHON=3.12 uv run --no-sync mypy switchyard
  • Confirmed nemo-switchyard remained uninstalled after both checks
  • Parsed .github/workflows/ci.yml as YAML
  • git diff --check

No live provider tests were run because this only changes setup for static-analysis jobs.

Notes for reviewers

This changes four workflow lines. The Python test, Rust, and package smoke-test jobs continue to install Switchyard normally. No product code, dependencies, lockfile, or public APIs change.

Signed-off-by: Alex Fournier <afournier@nvidia.com>
@afourniernv
afourniernv requested a review from a team as a code owner September 10, 2026 20:33
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d83e7122-e5f0-445e-9116-11bcce15eb20

📥 Commits

Reviewing files that changed from the base of the PR and between cb98af0 and 9e625a4.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


Walkthrough

The CI workflow now synchronizes locked dependencies without installing the project. The lint and typecheck jobs run Ruff and mypy without additional synchronization.

Changes

CI tool synchronization

Layer / File(s) Summary
Synchronize dependencies before checks
.github/workflows/ci.yml
The lint and typecheck jobs use uv sync --locked --no-install-project. Ruff and mypy run with uv run --no-sync.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 9e625

Static checks now avoid the unnecessary local project build while retaining locked Ruff and mypy environments. No merge-blocking production or product behavior risk is evident.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main CI change: static checks skip local project builds.

A rabbit checks the tools in line
Locked dependencies make them shine
Ruff hops first with steady feet
Mypy follows, quick and neat
No project install slows the beat

Comment @coderabbitai help to get the list of available commands.

@bhuvan002 bhuvan002 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bhuvan002
bhuvan002 merged commit 4e2f165 into main Sep 10, 2026
17 checks passed
@bhuvan002
bhuvan002 deleted the codex/ci-skip-project-builds branch September 10, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants