refactor(sc): unify capture retries and extract orchestration components - #4073
Draft
pthombre wants to merge 5 commits into
Draft
refactor(sc): unify capture retries and extract orchestration components#4073pthombre wants to merge 5 commits into
pthombre wants to merge 5 commits into
Conversation
added 5 commits
September 9, 2026 23:23
Signed-off-by: Pranav Thombre <pthombre@aws-cmh-slurm-1-vscode-01.cm.cluster>
Signed-off-by: Pranav Thombre <pthombre@aws-cmh-slurm-1-vscode-01.cm.cluster>
Signed-off-by: Pranav Thombre <pthombre@aws-cmh-slurm-1-vscode-01.cm.cluster>
Signed-off-by: Pranav Thombre <pthombre@aws-cmh-slurm-1-vscode-01.cm.cluster>
Signed-off-by: Pranav Thombre <pthombre@aws-cmh-slurm-1-vscode-01.cm.cluster>
4 tasks
pthombre
added this pull request to stack #4074
September 10, 2026 07:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Capture dispatch did not honor the legacy path's skipped-prompt budget, and retry accounting was duplicated. Share retry handling, make capture honor the budget and replacement policy, and extract the actor-pool and worker capture responsibilities into explicit components.
max_skipped_prompts; zero retains fail-fast behavior. Replacement selection and lineage/shortfall accounting remain checkpoint-atomic.RolloutReassemblerPoolwhile the controller retains its mutation cut across the RPC, replay-buffer commit, and recovery-ledger update. Unknown publication outcomes remain fatal and actors are not retried or reused.TokenCaptureHost, finish actor-field renaming, and preserve optional Gym imports, the pinned Gym contract, and existing dashboard metric keys.Issues
Follow-up to #3837. Cross-repository Gym route-fallback diagnostics are deferred.
PR stack
This is the second PR in the stack:
main→pranav/reassembler-group-fetch→pranav/capture-orchestration.Depends on #4072 (reassembler performance).
Base this PR on
pranav/reassembler-group-fetchso the diff contains only orchestration changes. After the performance PR merges, rebase/retarget this PR tomain.Validation
59eeafcf9b6be51352dc4fa39be5b98674f60ce9: completed with exit0:0.rl-gymcontainer and its Gym environment. Full multi-node training was not run.Before ready for review
This PR is intentionally a draft.