Skip to content

Enable clang-tidy misc checks - #314

Merged
scal444 merged 1 commit into
NVIDIA-BioNeMo:mainfrom
scal444:codex/clang-misc
Sep 22, 2026
Merged

scal444 merged 1 commit into
NVIDIA-BioNeMo:mainfrom
scal444:codex/clang-misc

Conversation

@scal444

@scal444 scal444 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@greptile-apps

greptile-apps Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The configuration-only change appears safe to merge, with no concrete correctness, security, or workflow failure identified.

Summary

This PR enables the clang-tidy misc-* check family while excluding checks that conflict with the repository's CUDA, RDKit, API, and style conventions.

  • Keeps all clang-tidy diagnostics configured as errors.
  • Preserves the existing source and header filtering policy.
  • Uses check names supported by the CI clang-tidy 22 toolchain.

Reviews (1) · Last reviewed commit: "Enable clang-tidy misc checks"

@scal444

scal444 commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

More towards #308

@scal444
scal444 requested a review from evasnow1992 September 19, 2026 14:04
@evasnow1992

Copy link
Copy Markdown
Collaborator

Unrelated to this PR, but it surfaced while checking: admin/Dockerfile.dev:28 installs clang-tidy-15, which can't parse this file's list-form Checks.

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@scal444

scal444 commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks, I'll take a look at all of our unused images and either update or remove them.

@scal444
scal444 merged commit 91a8555 into NVIDIA-BioNeMo:main Sep 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants