Skip to content

[Preview] [Testing] Single precision Minimizers - #306

Open
scal444 wants to merge 21 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/full-fp32-minimizers-pr
Open

scal444 wants to merge 21 commits into
NVIDIA-BioNeMo:mainfrom
scal444:codex/full-fp32-minimizers-pr

Conversation

@scal444

@scal444 scal444 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@scal444

scal444 commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator Author

This is not ready for official review, I"ll be breaking it into chunks for PRs.

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

The implementation appears safe to merge, with a non-blocking request to restore the reduced FULL-precision UFF regression coverage.

Findings

  1. P2 Full coverage is reduced

Summary

  • Adds precision-aware CUDA storage, arithmetic, reductions, Hessian state, and conversion workspaces.
  • Exposes PrecisionMode through the Python bindings and public optimization APIs.
  • Extends force-field and minimizer tests across both precision modes.
  • Documents precision behavior and the batched-backend requirement for SINGLE.

Reviews (1) · Last reviewed commit: "Remove precision implementation-history ..."

Comment on lines +63 to +64
# Small numeric differences select a different basin for the first molecule.
return molecules[1:]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Full coverage is reduced

This now drops the first UFF validation molecule for both precision modes and reduces the fixture from five molecules to four, although the stated basin instability only explains excluding it from SINGLE. This weakens the existing default FULL regression coverage while the force-field and minimizer implementations are being generalized. Please retain this molecule for FULL and apply any precision-specific expectation only to SINGLE. The same unconditional removal also appears in tests/test_uff.cu:301-302.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant