🐛 Fix(evaluation): run trials in runtime service - #3954
Open
cj2026-bit wants to merge 4 commits into
Open
cj2026-bit wants to merge 4 commits into
cj2026-bit wants to merge 4 commits into
Conversation
Route trial evaluations through the authenticated Config-to-Runtime proxy and use Config's manager only for creation-stage preparation. Keep Agent execution and evaluator scoring in Runtime. Co-authored-by: Codex <noreply@openai.com> Generated-by: gpt-5
cj2026-bit
requested review from
YehongPan,
hhhhsc701 and
jeffwu-1999
as code owners
September 18, 2026 08:08
Keep pure-logic service import tests aligned with the Config and Runtime thread-manager split. Co-authored-by: Codex <noreply@openai.com> Generated-by: gpt-5
Jasonxia007
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Evaluation APIs failed in the v2.6.0 / v2.6.1 environment with thread-manager errors:
ThreadManagerNotRunning: Thread manager for runtime is created.990105 Failed to run trial evaluation.Root cause
The issue was introduced by PR #3917, which unified thread lifecycle management and thread pools.
Config and Runtime are separate processes, and each process owns its own in-process thread-manager instances. The evaluation code used
runtime_thread_managerdirectly from the Config process. The Runtime manager is started only in the Runtime process, so the Config process's instance remained in theCREATEDstate and rejected task submission withThreadManagerNotRunning.The trial-run path had the same architectural problem: its public endpoint lived in Config but directly executed the Agent and evaluators in the Config process, relying on the unstarted local Runtime manager.
Solution
config_thread_managerfor Config-side preparation and dispatch work when creating an evaluation task.POST /agent-evaluations/trial-runAPI unchanged; Config continues to handle user authentication and request validation.runtime_thread_manager, avoiding direct cross-process thread-pool references.Validation
291 passed, 4 skipped.89.7%(reported as90%by the coverage summary).95.23%(target90%).Test screenshots