feat: add quote metadata migration phases 1.5 and 2 - #9744
Draft
micaelae wants to merge 93 commits into
Draft
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
micaelae
force-pushed
the
swaps4547-use-v2-migration
branch
from
August 7, 2026 01:11
363f891 to
8257447
Compare
micaelae
enabled auto-merge
August 7, 2026 01:15
micaelae
force-pushed
the
swaps4547-use-v2-migration
branch
from
August 7, 2026 01:33
cb46f5f to
3885f72
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3885f72. Configure here.
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
micaelae
changed the title
micaelae
marked this pull request as draft
August 13, 2026 17:57
auto-merge was automatically disabled
August 13, 2026 17:57
Pull request was converted to draft
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR enables clients to consume bridge-api's nested usd and fiat fields by specifying one of these migration phases:
QuoteMetadataMigrationPhase.V1Data(1): strip API V2 fee currency metadata; serve legacycalcQuoteMetadatain the V2 nested shapeQuoteMetadataMigrationPhase.V2WithV1Fallback(1.5): prefer API V2 metadata, convertusdamounts to fiat, fall back to legacy when the API field is not available. Top-level V1 metadata stays on the quote for client testingQuoteMetadataMigrationPhase.V2Only(2): API V2 metadata only; no legacy calcsubmitTx,submitIntent, andsubmitBatchSellalso accept the migrationPhase parameter. It is passed totoQuoteMetadataV1when converting V2 quotesTo integrate this change in the clients:
Draft client PRs
References
Related to https://consensyssoftware.atlassian.net/browse/SWAPS-4547
Checklist
Note
High Risk
Breaking API for all clients of
selectBridgeQuotesand submit flows; wrong phase can change displayed fees, fiat amounts, and pre-confirmation metrics until extension/mobile adopt the flag.Overview
Breaking:
selectBridgeQuotes(and related client params) now requiremigrationPhase, exported asQuoteMetadataMigrationPhase(V1Data,V2WithV1Fallback,V2Only). That flag controls whether quotes use legacycalcQuoteMetadata, API V2 nested fields with legacy fallback, or V2-only output (no legacy calc/flattened fields).Quote assembly is split by phase: legacy metadata calculation is skipped in V2Only;
toCurrencyValuesfills fiat from backendusdwhen phase is not V1Data;mergeQuoteMetadatais V2-only, takesmigrationPhaseplus optional currency overlays, and drops the old V1 merge path.toQuoteMetadataV1can rebuild legacy-shaped metadata from nested V2 data for submission/metrics.bridge-status-controller threads
migrationPhasethroughsubmitTx/submitIntent/submitBatchSelland builds V1 submission payloads viatoQuoteMetadataV1instead ofmergeQuoteMetadata. Tests and changelogs document the breaking API.Reviewed by Cursor Bugbot for commit 24fd854. Bugbot is set up for automated code reviews on this repo. Configure here.