merge queue: checking #1798 on main (5952690) - #1812
Closed
mergify[bot] wants to merge 2 commits into
Closed
Conversation
MRGFY-9001 cut the `ci` application key to what a CI job actually
needs, and `GET /ci/{owner}/repositories/{repo}/search/tests` lost
`ci_application_key` along with it. `tests_show_no_match` still
passed the CI-scoped token, so every live run since has failed with
a 403 on that one test — on pull requests that touch nothing near
it.
Reading test health is a developer inspecting a repository, not
something a CI job does, so the 403 is the intended answer and the
test was asserting an obsolete contract. It moves to the admin
token, under the admin banner with the queue and freeze tests that
were separated for the same reason.
The narrowing also took the two quarantine mutations the CLI makes
(`tests quarantines add` and `remove`); no live test covers those,
so they broke silently. Three doc surfaces promised any token
worked, and AGENTS.md makes README and `--help` the owners of the
token contract, so all three now say which key each command needs:
- `skills/mergify-ci/SKILL.md` grows one `## Authentication`
section glossing the two key classes, replacing the per-command
repetition the sibling merge-protections skill already avoids.
It also states the rule for the commands that keep working, so
the silence on `quarantines list`/`get` is readable rather than
looking like an oversight.
- README documents the split at group altitude, next to the
existing token resolution order.
- `--help` for the three affected commands says it inline. Those
doc comments feed `cli_schema.rs`, which the docs site renders,
so the golden snapshot moves with them.
While in that section: the `tests show` exit-code table claimed `1`
= flaky and `6` = broken, but `tests_show::run` returns
`ExitCode::Success` on every rendered path — pinned by
`unhealthy_tests_still_exit_success`. A CI gate written from that
table never fired, and it read this commit's own 403 (exit 6, a
`CliError`) as "a broken test". Corrected to what the command does.
Nothing in `Mergifyio/mergify-ci-integrations` is affected: its
whole API surface is `traces`, `quarantines` (list),
`flaky-detection-context` and `test-selection`, all of which the
narrowing kept.
Verified on CI: run 33880789655 reports `tests_show_no_match ... ok`
with 12/12 green, so the admin key does carry CI-Insights read
scope. `search/tests` is the only route the suite covers —
`tests/{test_id}` is narrowed the same way but the no-match query
returns before the details fetch, which the helper's doc now says.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JBz3hxMUDCuWftT6qAHtnn
Change-Id: I4e4c3e308adb7dbd68052ef9b03c2e42381dd8ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#1798 is queued for merge on branch main (5952690).
This pull request has been created by Mergify to check the mergeability of #1798.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub branch protection]tests showonto the admin token #1798github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]tests showonto the admin token #1798Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:tests showonto the admin token #1798👀 Review Requirements]:#approved-reviews-by>=2tests showonto the admin token #1798author = dependabot[bot]tests showonto the admin token #1798author = mergify-ci-bottests showonto the admin token #1798author = renovate[bot]tests showonto the admin token #1798📕 PR description]:body ~= (?ms:.{48,})tests showonto the admin token #1798🔎 Reviews]:#changes-requested-reviews-by = 0tests showonto the admin token #1798#review-requested = 0tests showonto the admin token #1798#review-threads-unresolved = 0tests showonto the admin token #1798🤖 Continuous Integration]:check-success=ci-gateRequired conditions to stay in the queue:
base=maintests showonto the admin token #1798github-review-approved[🛡 GitHub branch protection]tests showonto the admin token #1798github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]tests showonto the admin token #1798label!=manual mergetests showonto the admin token #1798Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:tests showonto the admin token #1798👀 Review Requirements]:#approved-reviews-by>=2tests showonto the admin token #1798author = dependabot[bot]tests showonto the admin token #1798author = mergify-ci-bottests showonto the admin token #1798author = renovate[bot]tests showonto the admin token #1798📕 PR description]:body ~= (?ms:.{48,})tests showonto the admin token #1798🔎 Reviews]:#changes-requested-reviews-by = 0tests showonto the admin token #1798#review-requested = 0tests showonto the admin token #1798#review-threads-unresolved = 0tests showonto the admin token #1798🤖 Continuous Integration]:check-success=ci-gatetests showonto the admin token #1798