fix: seed --settings into app's own file, not device settings.txt - #2
Merged
Conversation
`--settings` was merging the seed file into the device-root settings.txt (width/height/wifi), but most apps keep their own settings in a separate, relative-path file in their own directory (e.g. departures' `settings.txt`, clock's `clocksettings.txt`), so the seed was silently never read. Copy it verbatim into the app's own staged directory under its original filename instead, and warn when nothing in the app's own source references that filename. Also make the web UI's HTTP port ephemeral, like the frame server's, so it doesn't collide with another running `matrixbox` process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--settingswas merging the seed file into the device-root settings.txt (width/height/wifi), but most apps keep their own settings in a separate, relative-path file in their own directory (e.g. departures'settings.txt, clock'sclocksettings.txt), so the seed was silently never read. Copy it verbatim into the app's own staged directory under its original filename instead, and warn when nothing in the app's own source references that filename. Also make the web UI's HTTP port ephemeral, like the frame server's, so it doesn't collide with another runningmatrixboxprocess.