Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Fix the critical workload round-count mismatch before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR enables one client to distribute work across multiple GPUs while sharing binaries.
Changes:
- Adds multi-GPU runner distribution.
- Routes engine and benchmark processes to selected GPUs.
- Coordinates runner completion and result tracking.
File summaries
| File | Summary |
|---|---|
OpenBench/workloads/get_workload.py |
Enables multiple runner assignments. |
Client/worker.py |
Adds GPU routing and coordination; contains a critical -rounds mismatch at lines 413 and 1414. |
Client/bench.py |
Passes GPU indices to benchmark processes. |
Review details
Suppressed comments (1)
Client/worker.py:1414
- A runner clears
results['done']and continues after emitting its own completion marker, butbatch_doneis not set until every runner has reported. If one GPU is faster, it can enqueue additional result batches while another GPU is still finishing; those batches are then drained and uploaded, exceeding the allocatedrounds-per-runnerand potentially consuming another runner's opening range. Stop this runner when its owndoneresult is emitted, not only when the global event is set.
if batch_done.is_set():
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If server has many GPUs, test can suffer from concurrent compile for another GPU. We want use shared client and binaries for all GPUs to avoid compilation interfering with testing. This change allows running client with
-N <number of gpus>to use all GPUs using one client.