Skip to content

GitHub Issue 1509, 1510 & 1511: Workflow performance issues with large number of samples #7992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XingY wants to merge 1 commit into
base: release26.7-SNAPSHOT
Choose a base branch
from
+11 −0
Open

GitHub Issue 1509, 1510 & 1511: Workflow performance issues with large number of samples #7992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/src/org/labkey/api/exp/api/SampleTypeService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,8 @@ default Map<String, Long> incrementSampleCounts(@Nullable Date counterDate)

void addAuditEvent(User user, Container container, String comment, String userComment, ExpMaterial sample, Map<String, Object> metadata, String updateType);

void addAuditEvents(User user, Container container, String comment, String userComment, Collection<? extends ExpMaterial> samples, Map<String, Object> metadata);

// find the max sequence number with '${sampleName}-' prefix
long getMaxAliquotId(@NotNull String sampleName, @NotNull String sampleTypeLsid, Container container);

Expand Down
9 changes: 9 additions & 0 deletions experiment/src/org/labkey/experiment/api/SampleTypeServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,6 +1374,15 @@ public void addAuditEvent(User user, Container container, String comment, String
AuditLogService.get().addEvent(user, event);
}

@Override
public void addAuditEvents(User user, Container container, String comment, String userComment, Collection<? extends ExpMaterial> samples, Map<String, Object> metadata)
{
List<SampleTimelineAuditEvent> events = samples.stream()
.map(sample -> createAuditRecord(container, comment, userComment, sample, metadata))
.collect(Collectors.toList());
AuditLogService.get().addEvents(user, events);
}

@Override
public long getMaxAliquotId(@NotNull String sampleName, @NotNull String sampleTypeLsid, Container container)
{
Expand Down