test: replace unit-test module mocks with injected dependencies - #927
Open
PaulHax wants to merge 2 commits into
Open
test: replace unit-test module mocks with injected dependencies#927PaulHax wants to merge 2 commits into
PaulHax wants to merge 2 commits into
Conversation
✅ Deploy Preview for volview-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vtk.js only picks the widget under the cursor on its MouseMove event, and the interactor reports the first pointer move after ~200ms of stillness as StartMouseMove instead. A lone move therefore picks nothing, and any move clears the pick until an async render pass refills it, so a press dispatched right after one reads an empty pick and clears the selection. Hover by arriving from a nudge so the move that lands on the annotation is a MouseMove, wait for the view to show the hover cursor as proof the pick resolved, then press without moving so that pick still stands. Holding the pointer between chains needs a fixed action id and no release, as releasing resets it to the viewport origin. Retrying the click could not recover from this: on a runner where each iteration takes over 200ms every move is a StartMouseMove, which is why the macOS job failed while the same spec passed locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.