Skip to content

Fix TOSA RESCALE operands in tensor image aliasing sample - #1575

Open
bartosz-muszarski-arm wants to merge 1 commit into
KhronosGroup:mainfrom
bartosz-muszarski-arm:fix-tensor-image-aliasing-shader
Open

Fix TOSA RESCALE operands in tensor image aliasing sample#1575
bartosz-muszarski-arm wants to merge 1 commit into
KhronosGroup:mainfrom
bartosz-muszarski-arm:fix-tensor-image-aliasing-shader

Conversation

@bartosz-muszarski-arm

@bartosz-muszarski-arm bartosz-muszarski-arm commented Sep 11, 2026

Copy link
Copy Markdown

Change fixes crashing tensor_image_aliasing sample on strict compiler implementations

Problem

Proposed fix

  • use SINGLE_ROUND (value 1), provide a rank-1 i16 zero-point tensor for the i16 RESCALE and regenerate the checked-in SPIR-V binary

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

Problem
* the graph spirv used invalid RESCALE operands: rounding_mode = 0, and an i32 input zero-point for an i16 input
* this is invalid per spec https://github.khronos.org/SPIRV-Registry/extended/TOSA.001000.1.html#RESCALE
* strict graph compilers reject those operand/type combinations during graph pipeline creation.

Proposed fix
* use SINGLE_ROUND (value 1), provide a rank-1 i16 zero-point tensor for the i16 RESCALE and regenerate the checked-in SPIR-V binary

Change-Id: Iab5b65a1644054f033f665da786a6c6415ac8946
@CLAassistant

CLAassistant commented Sep 11, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants