Fix TOSA RESCALE operands in tensor image aliasing sample - #1575
Open
bartosz-muszarski-arm wants to merge 1 commit into
Open
Fix TOSA RESCALE operands in tensor image aliasing sample#1575bartosz-muszarski-arm wants to merge 1 commit into
bartosz-muszarski-arm wants to merge 1 commit into
Conversation
Problem * the graph spirv used invalid RESCALE operands: rounding_mode = 0, and an i32 input zero-point for an i16 input * this is invalid per spec https://github.khronos.org/SPIRV-Registry/extended/TOSA.001000.1.html#RESCALE * strict graph compilers reject those operand/type combinations during graph pipeline creation. Proposed fix * use SINGLE_ROUND (value 1), provide a rank-1 i16 zero-point tensor for the i16 RESCALE and regenerate the checked-in SPIR-V binary Change-Id: Iab5b65a1644054f033f665da786a6c6415ac8946
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change fixes crashing tensor_image_aliasing sample on strict compiler implementations
Problem
Proposed fix
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: