Skip to content

feat: check bank names for non-standard characters #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
c-dilks wants to merge 1 commit into
base: development
Choose a base branch
from
Open

feat: check bank names for non-standard characters #1398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions docs/zensical/src/banks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,16 @@ def table_row(out, cols)
"`#{spec['name'].gsub /::.*/, ''}`"
end.uniq

# check if the bank name has any funny characters
spec_list.each do |spec|
unless spec['name'].match? /\A[a-zA-Z:]+\z/
raise "bank '#{spec['name']}' has unexpected character(s)"
end
if spec['name'].gsub(/::/, '').match? /:/ # FIXME: won't catch `::::`, `::::::`, etc.
raise "bank '#{spec['name']}' has unexpected colon(s)"
end
Comment on lines +160 to +162

@c-dilks c-dilks Aug 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to decide on #1399 if we want to enforce double colons here

end

outMain.puts "\n## #{uniq_prefixes.join ', '} Banks"
outMain.puts "**Group ID:** #{group_id}\n\n"
table_row outMain, ['Item ID', 'Name', 'Description']
Expand Down
Loading