Skip to content

Avoid leaking module object on numpy C-API import failure #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonwolfy merged 2 commits into from
Sep 1, 2026
Merged

Avoid leaking module object on numpy C-API import failure #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e30fc8e
Avoid leaking module object on numpy C-API import failure
antonwolfy Aug 31, 2026
34f00db
Add changelog entry for module object leak fix
antonwolfy Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
* Fixed an over-decref of the borrowed module dictionary reference on the module initialization error path [gh-264](https://github.com/IntelPython/mkl_umath/pull/264)
* Fixed a leak of the module object when the NumPy C-API import fails during module initialization [gh-263](https://github.com/IntelPython/mkl_umath/pull/263)

## [0.5.0] - 2026-08-06

Expand Down
8 changes: 5 additions & 3 deletions mkl_umath/src/ufuncsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ PyMODINIT_FUNC PyInit__ufuncs(void)
PyObject *m;
PyObject *d;

/* NumPy C-API init macros: they `return NULL;` on failure, so call them
* before PyModule_Create() to avoid leaking the module on early return. */
import_array();
import_umath();

m = PyModule_Create(&_ufuncs_module);
if (m == NULL)
return NULL;
Expand All @@ -50,9 +55,6 @@ PyMODINIT_FUNC PyInit__ufuncs(void)
return NULL;
}

import_array();
import_umath();

if (InitOperators(d) < 0) {
/* d is a borrowed reference from PyModule_GetDict; do not decref it. */
Py_XDECREF(m);
Expand Down
Loading