feat(melodi): tests, docstrings, fix measures parsing - #308
GrasClement wants to merge 13 commits into
Conversation
Signed-off-by: GrasClement <gras.clement@orange.fr>
Signed-off-by: GrasClement <gras.clement@orange.fr>
Signed-off-by: GrasClement <gras.clement@orange.fr>
Signed-off-by: GrasClement <gras.clement@orange.fr>
Signed-off-by: GrasClement <gras.clement@orange.fr>
|
Hi, The JDOS are done, here is a quick closure summary for this PR, Bug Fixes
New Content
Code Maintenance
Cheers |
|
Thanks @GrasClement ! |
|
Hi @GrasClement , sorry I took so long to review this, I was overloaded at work. So I finally took the time to do it, with the exception of testing the documentation (I'm in a train on a personnal windows machine...) though it looks ok to me. I've made some comments: depending of your available time, feel free to let me know if you haven't the time to check all of this. In any case, thank you for both your great work and the effort to uniformize the API with the silent/update kwargs ❤️ ! |
|
Hi @tgrandje, no worries about the timing, and thanks for taking the time to review the PR! I don't seem to see any review comments or additional commits attached to the PR yet. Whenever you have a chance, could you check whether the comments were actually submitted? Or maybe the issue is on my side and I'm looking in the wrong place. I'd be happy to go through your feedback and update the PR once this is sorted out 😎 |
tgrandje
left a comment
There was a problem hiding this comment.
Sorry @GrasClement I forgot to submit the review 😳 !
| # Exception here: the bugs fixed in melodi/data/py live inside parsing helpers | ||
| # called inside get_dataset. Testing them through the real API would | ||
| # require downloading DS_IPC_PRINC on every test run. |
There was a problem hiding this comment.
Thanks for the explanations! As pynsee was never (yet) released with MELODI api, what do you think of removing the comments detailing the tests' purposes as fixes to my original branch? In case you're ok, I'll flag the involved comments I've seen.
There was a problem hiding this comment.
Reworded that one, and two more with the same "fix" framing I noticed, figured I'd just fix those I found rather than wait for you to flag them separately.
Signed-off-by: GrasClement <gras.clement@orange.fr>
Signed-off-by: GrasClement <gras.clement@orange.fr>
Signed-off-by: GrasClement <gras.clement@orange.fr>
|
Hi @tgrandje Replied to all your comments, thanks again for the thorough review, and sorry it took me a while to get back to it. Also found and fixed one unrelated thing while I was in there: the get_range docstring example was out of date. It might be because of an API change INSEE pushed in July, nothing to do with your comments. Let me know if anything needs another pass. I tried to finish cleanly to let new contributors jump in (see new comments in #307). Cheers :) |
Draft contribution aux JDOS : cible la branche #306
_parse_dataset_observations(voir package R Melodi)