fix(dref): active dref ops-update details issue - #2828
Open
susilnem wants to merge 1 commit into
Open
Conversation
…etched Users who reach a dref through Dref.get_for() (creator, dref.users, or shared only on the ops-update) lost operational_update_details because it depended solely on a prefetch that get_for's queryset doesn't carry. Falls back to a live query when the prefetch attr is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Users who were not superusers or region admins saw
operational_update_details: nullin the active DREF list, even when an operational update existed for that dref. This happened for dref creators, dref collaborators, and users shared only on the operational update itself. Reported in IFRCGo/go-web-app#2542.Changes
operational_update_detailsnow runs a normal database query when the prefetched data is missing, instead of returningnull.