Skip to content

Replace tslint with a working ESLint setup #116

Description

@zFernand0

Is your feature or enhancement request related to a problem or limitation? Please describe

The npm run lint script currently runs eslint, but there is no ESLint config file and no ESLint dependency anywhere in this repo. The only linter that's actually set up is tslint (tslint.json + the tslint package), but nothing calls it. In practice, linting has been silently broken for a while, it's either failing quietly or doing nothing.

On top of that, tslint itself has been deprecated since 2019, so even if we fixed the script to call it, we'd be investing in a dead tool.

Describe your enhancement idea

Remove tslint and tslint.json, and set up a real ESLint config instead (eslint + @typescript-eslint/parser + @typescript-eslint/eslint-plugin, using the newer flat-config style, i.e. eslint.config.js). Once that's in place, npm run lint should actually run and pass (or fail loudly with real, fixable issues) against everything in src/.

Describe alternatives you've considered

We could just fix the lint script to point at tslint, but that keeps us tied to a tool that its own maintainers stopped supporting years ago. Not worth it for the same amount of effort.

Provide any additional context

This is a good "do first" item. It's low risk, and it gives every other cleanup PR (TypeScript upgrade, removing the q dependency, swapping the FTP library) a working linter to check itself against.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions