size_t QuickVec and Appropriate BlockData Fields - #1402
Merged
Merged
Conversation
tobil4sk
reviewed
Sep 22, 2026
Contributor
Author
|
Merging since this new CI failure is also happening on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
QuickVecto be based onsize_tand updates the fields in theBlockDataclass to be "properly" sized. I didn't go with size_t for many of those fields as they can be much narrower. E.g. each block only has 256 lines (two of which are used for block metadata) and each line is 128 bytes long, souint8_tanduint16_tare natural fits for this.