feat(grpc): bypass DirectPath connectivity check for rapid buckets - #5027
Open
anushka567 wants to merge 4 commits into
Open
feat(grpc): bypass DirectPath connectivity check for rapid buckets#5027anushka567 wants to merge 4 commits into
anushka567 wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
remind-reviewers
anushka567
added
execute-integration-tests
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the gRPC client creation logic to skip DirectPath verification for rapid buckets and adds corresponding unit tests. The feedback suggests closing the newly created gRPC client in the unit tests to prevent potential resource leaks.
meet2mky
reviewed
Aug 14, 2026
| @@ -209,17 +209,16 @@ func createGRPCClientHandle(ctx context.Context, clientConfig *storageutil.Stora | |||
|
|
|||
| // Set the production level retry config. | |||
| defer func() { | |||
Collaborator
There was a problem hiding this comment.
This defer shouldn't be required right? because we never mutate the client retry policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the
createGRPCClientHandlelogic to bypass theverifyDirectPathConnectivitydummy-stat check for Rapid (and Pirlo) buckets.Since Rapid buckets primarily rely on gRPC for high throughput and bidirectional streaming, skipping this verification eliminates unnecessary initialization latency and potential connection failures on startup. DirectPath verification failures remain strictly fatal for standard regional buckets.
Test Determinism: Explicitly set
AnonymousAccess = truein the standard test to strip environment credentials (e.g., GCE Application Default Credentials). This ensures the dummyAttrscall strictly fails with aPermissionDeniedrather than authenticating and returning aNotFound(which the check ignores), guaranteeing deterministic failures across all CI environments.Link to the issue in case of a bug fix.
Testing details
Any backward incompatible change? If so, please explain.
No.