chore: Dependabot updates for other-deps (resolve PR 4979 conflicts) - #4995
Open
alleaditya wants to merge 3 commits into
Open
chore: Dependabot updates for other-deps (resolve PR 4979 conflicts)#4995alleaditya wants to merge 3 commits into
alleaditya wants to merge 3 commits into
Conversation
Bumps alpine from 3.21 to 3.24. --- updated-dependencies: - dependency-name: alpine dependency-version: '3.24' dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
# Conflicts: # go.mod # go.sum
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the base image in the Dockerfile to Alpine 3.24 and upgrades several Go dependencies in go.mod and go.sum. Feedback points out that Alpine version 3.24 does not exist, which will cause the Docker build to fail, and suggests reverting to a valid version like 3.21.
| RUN build_gcsfuse . /tmp $(git log -1 --format=format:"%H") | ||
|
|
||
| FROM alpine:3.21 | ||
| FROM alpine:3.24 |
Contributor
There was a problem hiding this comment.
Alpine version 3.24 does not exist. The latest stable version of Alpine is 3.21. Using a non-existent version will cause the Docker build to fail. Please revert this change or use a valid Alpine version.
FROM alpine:3.21
anushka567
added
execute-integration-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependabot PRs.
These are updates to other-deps.
Link to the issue in case of a bug fix.
NA
Testing details
Any backward incompatible change? If so, please explain.
NA