Conversation
furtib
force-pushed
the
codechecker-store
branch
from
September 9, 2026 08:17
a50dbde to
e8550e8
Compare
nettle
reviewed
Sep 9, 2026
Comment on lines
+25
to
+45
| ```python | ||
| codechecker_test( | ||
| name = "codechecker", | ||
| targets = [ | ||
| "your_target", | ||
| ], | ||
| ) | ||
|
|
||
| codechecker_store( | ||
| name = "store", | ||
| targets = [ | ||
| ":codechecker", | ||
| ], | ||
| ) | ||
| ``` | ||
|
|
||
| Then run it, passing the server URL and a run name: | ||
|
|
||
| ```bash | ||
| bazel run //:store -- --url=http://localhost:8001/Default --name=my_run | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Hi @furtib,
This is very interesting approach! Thanks for this prototype!
But I have many practical questions, for instance:
- What if
:codecheckertest fails? - How to handle credentials?
Let's discuss!
Contributor
Author
There was a problem hiding this comment.
Hi!
Thanks for taking a look so fast!
- The
:codecheckertest actually fails in this case! - Credentials: I have little experience in this part, so please help me out with how you might use it, but I have tested this solution by running
CodeChecker cmd loginbefore it, and it worked. - On another note: other command-line arguments.
I have changed it so we capture everything after--and pass it to CodeChecker. This should work for most arguments. One notable exception is the config file one; I think I should integrate this into the rule, otherwise users must use absolute paths for this.
Contributor
Author
There was a problem hiding this comment.
Do note that since bazel run is interactive, we could also prompt the user.
Contributor
Author
|
Superseded by #332. |
Contributor
Author
|
whoops, didn't meant to close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want to be able to run codechecker store easily.
What:
bazel runrulecodechecker_store.This rule:
Addresses:
#90
Additional notes:
You can try this by running one of the following:
The store script runs inside the Bazel runfiles directory. (My understanding is that it's very similar to the sandbox but it cannot write to it.) If we exposed the source files also, they would also be inside this runfiles directory, removing the need to remove things like
_virtual_includesfrom the plist files paths. Basically, it should be much easier to resolve the paths in the plist files to a source file here.