You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently available as bethcimini/distributed-cellprofiler:2.2.1_4.2.8_fixatt4 ; had one small-scale test but would be great to have a larger test before we pull!
Thanks Beth!
Do you mind explaining briefly what the other fixes we tested were (since I know not all of them worked) so that we have a record here in case this needs to be revisited again for some reason?
Previously, inside cpworker, we os.listdired the bucket root and then subprocess lsed one level down. Exactly WHY that very strange combo is lost to time inside my brain, though possibly a more diligent search of 2016-era issues/commits might turn up if other things were tried.
Fully removing any ls of the mounted system was the only thing that caused bucket mounting to break(per my understanding - I made the containers but did not personally test them). Keeping either an os.listdir OR subprocess call to ls inside the cpworker script at only a single level worked to mount the bucket. So did a two-level ls in run_worker (aka ls /home/ubuntu/bucket/*/) . But since the cpworker script runs every job, and the run_worker script runs only on container mount, this solution (ls /home/ubuntu/bucket/ ) generates the minimal "touches" (and therefore costs) that still preserve functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #214
Currently available as
bethcimini/distributed-cellprofiler:2.2.1_4.2.8_fixatt4; had one small-scale test but would be great to have a larger test before we pull!