New component: Secondary Nav (Sidebar expansion) - #262
Open
zoharma wants to merge 5 commits into
Open
Conversation
zoharma
force-pushed
the
zma/sidebar-expansion
branch
from
August 3, 2026 14:59
bc74614 to
02a980e
Compare
zoharma
marked this pull request as ready for review
August 3, 2026 15:02
zoharma
marked this pull request as draft
August 4, 2026 09:13
zoharma
marked this pull request as ready for review
August 4, 2026 14:07
2 tasks
zoharma
force-pushed
the
zma/sidebar-expansion
branch
from
August 6, 2026 11:32
02a980e to
b0bbd36
Compare
zoharma
force-pushed
the
zma/sidebar-expansion
branch
3 times, most recently
from
August 11, 2026 13:56
191232a to
08739a2
Compare
Contributor
Author
|
@douglaswinter Have updated a few things:
|
zoharma
force-pushed
the
zma/sidebar-expansion
branch
from
August 11, 2026 15:30
75332bf to
eb52c53
Compare
douglaswinter
requested changes
Aug 17, 2026
douglaswinter
left a comment
douglaswinter
left a comment
Collaborator
There was a problem hiding this comment.
It looks good, but I think it could do with some refactoring.
…vigation - Introduce `SecondaryNav` and `NavigationLayout` components to support a secondary, contextual navigation panel alongside the primary SidebarNav. - Extract shared `LinkProps` into types.ts so both nav components can reuse it.
… presentation - fixed `WithAppBar` story: selection state was hardcoded to "Acquisition" and now fixed. - Split `SecondaryNav` content from its responsive layout, making it reusable (such as in modals). - Fixed mobile navigation so selecting a secondary item closes both sidebars and shows the main content. - Updated tests and stories.
zoharma
added a commit
that referenced
this pull request
Aug 24, 2026
Addresses PR #262 review feedback: - SidebarNav now owns the responsive primary/secondary panel coordination directly instead of through a separate NavigationLayout component, and the secondary-panel component is renamed to SubNav for clarity. - Also consolidates shared nav item types, drops the id field in favour of generated keys, replaces the search prop with a searchSlot, now showing of SidebarNav stories, and updated test statements
zoharma
force-pushed
the
zma/sidebar-expansion
branch
4 times, most recently
from
August 24, 2026 15:35
3586798 to
f7d28a9
Compare
zoharma
added a commit
that referenced
this pull request
Aug 24, 2026
* Move responsive primary/secondary panel coordination into `SidebarNav` * Rename the secondary panel component to `SubNav` * Consolidate shared nav item types and use generated keys instead of `id` * Replace the `search` prop with `searchSlot` * Improve `SidebarNav` story coverage and clean up story canvases * Update test assertions * Fix drawer/content height mismatch
zoharma
force-pushed
the
zma/sidebar-expansion
branch
from
August 24, 2026 15:40
f7d28a9 to
bec981b
Compare
- Move responsive primary/secondary panel coordination into `SidebarNav` - Rename the secondary panel component to `SubNav` - Consolidate shared nav item types and use generated keys instead of `id` - Replace the `search` prop with `searchSlot` - Improve `SidebarNav` story coverage and clean up story canvases - Update test assertions - Fix drawer/content height mismatch
zoharma
force-pushed
the
zma/sidebar-expansion
branch
3 times, most recently
from
August 24, 2026 16:09
585c12c to
0914e44
Compare
- Replace `SubNav`'s `searchSlot` with `beforeNavSlot`, `afterNavSlot`, and `footerSlot` - Add `hasAppBar` to `SidebarNav`, defaulting to `false`, so the Toolbar spacer is only rendered when needed - Align subheaders, expandable-item children, and slot content with nav item text - Replace the expand/collapse chevron with Lucide's `ChevronDown` - Expand SidebarNav and SubNav story docs with usage guidance
zoharma
force-pushed
the
zma/sidebar-expansion
branch
from
August 24, 2026 16:17
0914e44 to
f5e858c
Compare
Contributor
Author
|
@douglaswinter Went through this today: In two commits here are the changes: Address SidebarNav review feedback:
Additional changes and fixes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #274
This proposed changes rely on #210.
Added a SecondaryNav panel that sits alongside SidebarNav, with support for a title, search, and grouped or expandable lists. Also added NavigationLayout, which combines both navigation panels and handles responsive behaviour automatically, showing them side by side on desktop and switching between them on mobile.
The secondary navigation uses compact rows and the same rounded selection style as the primary sidebar. Shared navigation types have been moved to
navigation/types.ts.Also added history for back button