fix(jira): correct the exception class the webhook lookups catch - #15931
Open
svader0 wants to merge 1 commit into
Open
fix(jira): correct the exception class the webhook lookups catch#15931svader0 wants to merge 1 commit into
svader0 wants to merge 1 commit into
Conversation
The two JIRA_Issue lookups in the webhook caught JIRA_Instance.DoesNotExist, which the query never raises, so the response they were written to return never fired and the request fell through to the general handler instead. Catch the exception the query actually raises. Move failure detail to the server log so the general handler returns a fixed response.
svader0
force-pushed
the
harden-jira-webhook-error-response
branch
from
September 11, 2026 19:00
0eec550 to
8f32f03
Compare
svader0
changed the title
|
This pull request contains a critical finding where the sensitive file 'dojo/jira/views.py' was modified by an unauthorized author, 'svader0'.
🔴 Configured Sensitive Codepath Modified by Non-Allowed Author in
|
| Vulnerability | Configured Sensitive Codepath Modified by Non-Allowed Author |
|---|---|
| Description | File 'dojo/jira/views.py' matches configured sensitive codepath pattern 'dojo/jira/*.py' and was modified by 'svader0' (commit 8f32f03) who is not in the allowed authors list. |
We've notified @mtesauro.
Comment to provide feedback on these findings.
Report false positive: @dryrunsecurity fp [FINDING ID] [FEEDBACK]
Report low-impact: @dryrunsecurity nit [FINDING ID] [FEEDBACK]
Example: @dryrunsecurity fp drs_90eda195 This code is not user-facing
All finding details can be found in the DryRun Security Dashboard.
blakeaowens
approved these changes
Sep 12, 2026
Maffooch
approved these changes
Sep 12, 2026
devGregA
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening and consistency improvement to the Jira webhook error handling.
Two lookups caught an exception class the query does not raise, so the response they were written to return never fired. This corrects the exception class, and moves failure detail to the server log so the handler returns a fixed response.
Adds two regression tests. No functional change for a correctly configured Jira.