stocks: add expand_all to stocks interface - #5809
Merged
Merged
Conversation
ab9rf
reviewed
Jul 11, 2026
| for idx=0,num_sections-1 do | ||
| stocks.current_type_a_expanded[idx] = true | ||
| end | ||
| stocks.i_height = num_sections * 3 |
Member
There was a problem hiding this comment.
I'm uncertain that this is the correct thing to do here, but I also don't understand why collapse_all does the same thing. So if someone could explain this to me, it would help me feel better about approving this change.
Member
There was a problem hiding this comment.
I think you were right to be suspicious. stocks.i_height appears to be the total height of the right hand side (in interface lines, 3 per entry). When expanding all entries, the total height of the right inside could be computed as simply as:
Suggested change
| stocks.i_height = num_sections * 3 | |
| num_items = #stocks.current_type_i_list | |
| stocks.i_height = (num_items + num_sections) * 3 |
Contributor
Author
There was a problem hiding this comment.
thank you for the clarification, I've updated the branch to reflect your suggested way of computing it
ab9rf
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5338