Add 26.3 modpacks and retire 26.2 from CI - #89
Conversation
26.3 supersedes 26.2, so the CI matrix and the Renovate version rules move over to it. The 26.2 packs stay in the repo for reference, but are no longer tested and are excluded from automatic dependency updates. theoneprobe and Curios have no 26.3 build yet, so they are commented out in cyclops-all-deps with a note. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Two separate failures on the first run: * The gametest datapack I added for 26.3 registers an IntegratedCrafting recipe serializer, but IntegratedCrafting is NeoForge-only, so the Fabric and Forge cyclops-all servers failed registry loading and refused to start. The sibling packs declare pack formats that no current Minecraft version accepts, so they never load and never hit this; dropping the 26.3 pack restores that same behaviour. * mc-runtime-test 4.5.1 has no 26.3 build, so the client jobs die with "Asset with name mc-runtime-test-26.3-*-neoforge-release.jar not found!". Exclude them until it ships one, the same way 26.2 client tests were excluded until 4.5.0. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Correcting the previous commit: the packs were never inert. They load on every version, and removing the 26.3 one only changed which pack the error names, since all three define the same recipe id and the last one wins. The recipes are Integrated Crafting ones, and Integrated Crafting only exists on NeoForge. Up to 26.2 an unknown recipe type in a datapack was skipped, so the Fabric and Forge servers came up anyway; 26.3 fails registry loading over it and refuses to start. Drop the datapacks on the loaders that cannot use them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
|
Two reasons it is not this PR's:
No fix exists for me to port, so I am not widening this PR with one. I will re-run the job once when the run finishes and report what comes back. If it fails again on an unchanged 26.1.2 pack, it is a real pre-existing failure on master and deserves its own issue rather than blocking this. The 26.3 jobs are what this PR is responsible for, and those are covered by the two fixes already pushed. Generated by Claude Code |
|
Correction to my previous comment: I was wrong that no fix exists. One does, and it is already in flight here. CyclopsMC/EvilCraft#1263, "Fix random failures of blood infuser game tests" (19 Sep), rewrote The packs were simply pinned below it. I checked the published sources jars directly:
That also explains why 26.3 was unaffected: it pins #88 already bumps Generated by Claude Code |
Adds Minecraft 26.3 to the pack tests. 26.3 supersedes 26.2, so 26.2 is dropped from CI and from the Renovate rules; its pack
pom.xmlfiles stay in the repo for reference. 1.21.1 and 26.1.2 are untouched.Modpacks
Five new packs, mirroring the 26.2 layout:
cyclops-allon neoforge, forge and fabric, pluscyclops-all-depsandcyclops-idon neoforge. Mod versions are the current 26.3 releases:1.30.0-11622.11.8-4011.1.9-2560.2.14-2452.2.3-2442.5.10-4091.2.0-2781.8.16-3211.4.2-2341.33.4-21691.9.6-7981.4.7-8031.7.0-10131.0.22-4951.1.15-2201.6.1-861.2.98-1114Third-party dependencies in
cyclops-all-deps: JEI26.3-neoforge:31.1.0.13, TerraBlender26.3-26.3.0.0.0, Jade8892782(Jade-mc26.3-NeoForge-26.3.1).theoneprobe and Curios have no 26.3 build, so both are commented out with a note. theoneprobe's latest is
26.2_neo-15.0.1-2and Curios' is16.0.0+26.2. Leaving either at its 26.2 artifact would break the pack at load: that is exactly how Jade's 26.2 build behaved when EvilCraft-Compat was ported, dying withNoSuchMethodError: VanillaRegistries.createLookup()before any test ran.CI
The
mcmatrix entry26.2becomes26.3, and the Fabricincludeentry moves tofabric-api: 0.161.0withfabric-gametest-api: 4.0.32+3434d6d95d. That pairing is not guesswork: it is thefabric-gametest-api-v1version thatfabric-api:0.161.0+26.3itself depends on, read from its POM.Renovate
The per-MC-line
allowedVersionsrules for TerraBlender, theoneprobe, Architectury and Refined Storage move frommodpacks/**/26.2*/**tomodpacks/**/26.3*/**. Architectury's major goes21→22, which is the major that declaresminecraft [26.3,)in itsneoforge.mods.toml.Since the 26.2 packs are unmaintained,
ignorePathskeeps Renovate away from them rather than having it keep opening auto-merging update PRs for packs nothing tests. Note this overrides theignorePathsinherited fromconfig:recommended, which is harmless here as the repo holds only POMs and workflows.A pre-existing problem I did not touch
run/world/datapacks/cyclopsmc-gametests-26-1-2/pack.mcmetadeclaresmin_format: 82, max_format: 88. Those are resource pack numbers (26.1.2 is 84, 26.2 is 88), not data pack formats: the data pack formats are 101 for 26.1.2 and 107 for 26.2. So that pack looks incompatible to both versions it is meant to serve, which would mean the two IntegratedCrafting recipes in it have not been loading. CI is green regardless, so either the recipes are no longer needed or incompatible world datapacks still load.I did not change it, since it is outside this PR's scope and the answer decides whether it is a real bug or dead weight. The new
cyclopsmc-gametests-26-3pack declares121, which is 26.3's actual data pack format, read fromversion.jsonin the 26.3 client jar and cross-checked againstmisode/mcmeta.Validation
All five new packs resolve completely with the repo's own
./fetch.sh, against the samesettings.xmlCI uses:renovate.jsonis still valid JSON.🤖 Generated with Claude Code
https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Generated by Claude Code