Update to Minecraft 26.3 - #20
Merged
Merged
Conversation
* org.lwjgl.glfw is gone, and InputConstants#isKeyDown no longer takes a window; GLFW_KEY_LEFT_SUPER/RIGHT_SUPER are the SDL scancodes KEY_LGUI/KEY_RGUI * Replace the deprecated logoFile with iconFile REI and Curios have no 26.3 build yet, so those two stay pinned to their 26.2 artifacts. Curios is only referenced as a mod id string, and the REI dependency is compileOnly, so neither ends up on the runtime classpath. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Coverage Report for CI Build 35523529525Coverage remained the same at 3.85%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions46 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports IntegratedTerminals-Compat to Minecraft 26.3 (NeoForge
26.3.0.7-beta), now that CyclopsMC/IntegratedTerminals#227 is merged and published.Dependency versions bumped to the 26.3 builds: CyclopsCore
1.30.0-1159, IntegratedDynamics1.33.4-2157, IntegratedCrafting1.4.7-803, IntegratedTunnels1.9.6-795, IntegratedTerminals1.7.0-1010, CommonCapabilities2.11.8-398, JEI26.3-neoforge:31.1.0.13, cloth-config26.3.158, architectury22.0.2. Also bumps the moddev plugin to2.0.147.Changes
Only one compile error, in
RecipeTransferHelpers.org.lwjgl.glfwis gone, andInputConstants#isKeyDownlost itsWindowargument now that it reads SDL's keyboard state directly.GLFW_KEY_LEFT_SUPER/GLFW_KEY_RIGHT_SUPERbecome the SDL scancodesInputConstants.KEY_LGUI(227) andKEY_RGUI(231), which are the same physical keys. That flag is what makes a JEI/REI recipe transfer also start crafting jobs for missing ingredients.logoFileis deprecated, soneoforge.mods.tomlusesiconFile.REI and Curios have no 26.3 build
Both are still pinned to their 26.2 artifacts, because neither has released for 26.3 (REI's latest is
26.2.821from 2026-07-29, Curios' is16.0.0+26.2from 2026-07-21). Neither reaches the runtime classpath:Reference, so the:apidependency is compile-time dead weight.compileOnly, and the REI compat sources still compile against the 26.2 API unchanged. If REI's API turns out to have changed when it does release for 26.3, that will surface then; the alternative would be excludingmodcompat/reithe waymodcompat/emialready is, which would drop REI support outright.Validation
./gradlew buildpasses../gradlew runGameTestServer: all 83 required tests pass. The two remaining loot table warnings come from the IntegratedDynamics dependency jar and are fixed by Update the loot tables to the 26.3 format IntegratedDynamics#1743.251 / 2,673.RecipeTransferHelpers.transferRecipefilled the grid with 4 oak planks pulled from network storage, produced the Crafting Table in the output slot, and dropped the network count to247 / 2,673. That is the changed file's whole path, including theisKeyDowncall whose result the packet carries.InputConstants.isKeyDown(KEY_LGUI)andisKeyDown(KEY_RGUI)evaluate without error and report not-held, confirming the new single-argument overload and scancodes resolve at runtime.🤖 Generated with Claude Code
https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Generated by Claude Code