Skip to content

Update to Minecraft 26.3 - #20

Merged
rubensworks merged 1 commit into
master-26from
claude/minecraft-26-3-update-xr1cny
Sep 20, 2026
Merged

rubensworks merged 1 commit into
master-26from
claude/minecraft-26-3-update-xr1cny

Conversation

@rubensworks

Copy link
Copy Markdown
Member

Ports IntegratedTerminals-Compat to Minecraft 26.3 (NeoForge 26.3.0.7-beta), now that CyclopsMC/IntegratedTerminals#227 is merged and published.

Dependency versions bumped to the 26.3 builds: CyclopsCore 1.30.0-1159, IntegratedDynamics 1.33.4-2157, IntegratedCrafting 1.4.7-803, IntegratedTunnels 1.9.6-795, IntegratedTerminals 1.7.0-1010, CommonCapabilities 2.11.8-398, JEI 26.3-neoforge:31.1.0.13, cloth-config 26.3.158, architectury 22.0.2. Also bumps the moddev plugin to 2.0.147.

Changes

Only one compile error, in RecipeTransferHelpers. org.lwjgl.glfw is gone, and InputConstants#isKeyDown lost its Window argument now that it reads SDL's keyboard state directly. GLFW_KEY_LEFT_SUPER / GLFW_KEY_RIGHT_SUPER become the SDL scancodes InputConstants.KEY_LGUI (227) and KEY_RGUI (231), which are the same physical keys. That flag is what makes a JEI/REI recipe transfer also start crafting jobs for missing ingredients.

logoFile is deprecated, so neoforge.mods.toml uses iconFile.

REI and Curios have no 26.3 build

Both are still pinned to their 26.2 artifacts, because neither has released for 26.3 (REI's latest is 26.2.821 from 2026-07-29, Curios' is 16.0.0+26.2 from 2026-07-21). Neither reaches the runtime classpath:

  • Curios is only referenced as a mod id string in Reference, so the :api dependency is compile-time dead weight.
  • The REI dependency is compileOnly, and the REI compat sources still compile against the 26.2 API unchanged. If REI's API turns out to have changed when it does release for 26.3, that will surface then; the alternative would be excluding modcompat/rei the way modcompat/emi already is, which would drop REI support outright.

Validation

  • ./gradlew build passes.
  • ./gradlew runGameTestServer: all 83 required tests pass. The two remaining loot table warnings come from the IntegratedDynamics dependency jar and are fixed by Update the loot tables to the 26.3 format IntegratedDynamics#1743.
  • Checked in a 26.3 dev client with clientdevbridge, on a cable network with a Storage Terminal part and an Item Interface reading a chest holding 64 redstone, 42 diamonds, 17 iron ingots, 64 oak planks and 64 sticks:
    • The mod loads alongside JEI, the terminal opens, and the Item Crafting tab draws its 3×3 grid with the network contents at 251 / 2,673.
    • Driving the crafting-table recipe through RecipeTransferHelpers.transferRecipe filled the grid with 4 oak planks pulled from network storage, produced the Crafting Table in the output slot, and dropped the network count to 247 / 2,673. That is the changed file's whole path, including the isKeyDown call whose result the packet carries.
    • InputConstants.isKeyDown(KEY_LGUI) and isKeyDown(KEY_RGUI) evaluate without error and report not-held, confirming the new single-argument overload and scancodes resolve at runtime.
    • No exceptions in the client log beyond the headless environment's OpenAL failure.

🤖 Generated with Claude Code

https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf


Generated by Claude Code

* org.lwjgl.glfw is gone, and InputConstants#isKeyDown no longer takes
  a window; GLFW_KEY_LEFT_SUPER/RIGHT_SUPER are the SDL scancodes
  KEY_LGUI/KEY_RGUI
* Replace the deprecated logoFile with iconFile

REI and Curios have no 26.3 build yet, so those two stay pinned to their
26.2 artifacts. Curios is only referenced as a mod id string, and the REI
dependency is compileOnly, so neither ends up on the runtime classpath.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 35523529525

Coverage remained the same at 3.85%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 46 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

46 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
org/cyclops/integratedterminalscompat/modcompat/common/RecipeTransferHelpers.java 46 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 793
Covered Lines: 38
Line Coverage: 4.79%
Relevant Branches: 350
Covered Branches: 6
Branch Coverage: 1.71%
Branches in Coverage %: Yes
Coverage Strength: 0.15 hits per line

💛 - Coveralls

@rubensworks
rubensworks merged commit b80089a into master-26 Sep 20, 2026
3 checks passed
@rubensworks
rubensworks deleted the claude/minecraft-26-3-update-xr1cny branch September 20, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants