Shadow IntegratedDynamics-Compat again - #1739
Merged
Merged
Conversation
CyclopsMC/IntegratedDynamics-Compat#44 is merged and its master-26 run published 1.0.0-218, so the shadow dependency that the 26.3 update had to comment out can come back. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the circular unblock from the 26.3 update.
IntegratedDynamics-Compat compiles against this mod's
slimartifact while this mod shadows the compat jar, so neither could build for 26.3 until the other had published. #1738 broke that by commenting the compatshadowentry out with a TODO and publishing first. CyclopsMC/IntegratedDynamics-Compat#44 then built againstintegrateddynamics 1.33.4-2151and published1.0.0-218, so the dependency can come back.integrateddynamicscompat_versionmoves from the1.0.0-202placeholder (a 26.2 build) to the published26.3-neoforge:1.0.0-218.shadowblock inbuild.gradleis uncommented, and both TODOs are gone.Verified
With
secrets.propertiesremoved entirely, which is what CI does:integrateddynamicscompat-26.3-neoforge:1.0.0-218resolves on theshadowconfigurationbuildpasses and all 1001 game tests passintegrateddynamicscompatclasses, against 0 while the dependency was commented outOn the Meneglin biome
The compat module is what injects the Meneglin biome into the overworld, through TerraBlender, so this restores that wiring.
To be precise about what that does and does not mean: the injection is an
IModCompatkeyed on TerraBlender, and this mod declares no TerraBlender dependency, so the biome generates only for users who have TerraBlender installed. While the shadow was commented out it could not generate even for them. I was not able to confirm generation end to end in a dev client, because TerraBlender is not on this mod's dev runtime or in its repositories; the evidence here is the restored wiring plus the class count above.🤖 Generated with Claude Code
https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Generated by Claude Code