Update the loot table to the 26.3 format - #45
Merged
Merged
Conversation
26.3 replaced the "functions"/"conditions" lists on tables, pools and entries with a single "modifier"/"condition" holder, and the inline "function"/"condition" type keys with "type". The old format parses without any error and is then ignored, so every loot function and condition in these tables had silently become a no-op. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Coverage Report for CI Build 35520648744Coverage remained the same at 64.751%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the 26.3 port.
26.3 replaced the
"functions"/"conditions"lists on loot tables, pools and entries with a single"modifier"/"condition"holder, and renamed the inline"function"/"condition"type keys to"type". The old format parses without any error and is then ignored, so the flopper'scopy_nameandsurvives_explosionhad silently become no-ops.I found this while porting EvilCraft, where the same problem made a Dark Tank drop lose its capacity, and confirmed it in IntegratedDynamics (CyclopsMC/IntegratedDynamics#1743), where the dropped conditions show up as
Unreachable entry!validation warnings.Validation
./gradlew buildpasses../gradlew runGameTestServer: all 13 tests pass on every loader, with no loot table validation warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Generated by Claude Code