Replace the deprecated logoFile with iconFile - #44
Merged
Merged
Conversation
NeoForge 26.3 deprecated logoFile in favour of bannerFile and iconFile, and warns about it on every dev client launch. The logo is square, so iconFile is the fitting replacement. Only the NeoForge manifest changes: Forge 26.3 still only understands logoFile, so its mods.toml is left as is. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Coverage Report for CI Build 35510497854Coverage remained the same at 64.751%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeoForge 26.3 deprecated the
logoFilemanifest property in favour ofbannerFileandiconFile, andLogoFileWarningsHandlerraises a loading warning for every mod still using it. It shows a "Warnings while loading mods" screen on each dev client launch.The logo is 512x512, i.e. square, so
iconFileis the fitting replacement of the two. In NeoForge'sDefaultModDisplayInfo,icon()reads onlyiconFile, whilebanner()falls back throughbannerFilethenlogoFile.Only the NeoForge manifest is changed. Forge 26.3 still understands only
logoFile: itsfmlloadercontains no reference toiconFileorbannerFile, soloader-forge/src/main/resources/META-INF/mods.tomlis deliberately left alone. Changing it there would lose the logo on Forge.Verified by relaunching a dev client: the warning count dropped from 3 to 2, with the fixed mod gone from the list and only the two mods still loading from their previously published jars remaining.
Note the warning is dev-only —
LogoFileWarningsHandlerreturns early whenFMLEnvironment.isProduction()— so this never affected players.🤖 Generated with Claude Code
https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Generated by Claude Code