Update to Minecraft 26.3 - #9
Merged
Merged
Conversation
SlotDisplay$TagSlotDisplay now carries a HolderSet<Item> instead of a TagKey<Item>, so the tag name is resolved via HolderSet#unwrapKey. Anonymous holder sets fall through to the stack-resolving branch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
rubensworks
pushed a commit
to CyclopsMC/CommonCapabilities
that referenced
this pull request
Sep 20, 2026
CyclopsMC/CommonCapabilitiesAPI#9 was squash-merged, so the branch this pointed at is gone and its commit is no longer reachable. master-26 now carries the 26.3 fix, along with two intervening commits that this mod already had the ingredient package and helpers for. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SlotDisplay$TagSlotDisplaynow carries aHolderSet<Item>instead of aTagKey<Item>, which is the only thing in this repository that 26.3 breaks. BothgetPrototypesFromDisplayoverloads pattern-match on it, so both fail to compile:The tag name now comes from
HolderSet#unwrapKey. That returns anOptional, because aHolderSetis not necessarily a named tag — an anonymous one has no name to put in aPrototypedIngredientAlternativesItemStackTag. The guard is part of the pattern condition, so those fall through to the existing branch that resolves the display into concrete stacks, which is the behaviour that branch already had for every other display type.The fix commit is based on the commit CyclopsCore pins (
7cc8eb2), andmaster-26is then merged in, so the branch head ismaster-26plus this fix and the net diff againstmaster-26is exactly the 26.3 change. That head is what CyclopsMC/CommonCapabilities#50 points its submodule at; CyclopsMC/CyclopsCore#243 points at the fix commit itself, which is an ancestor of this branch.Needed by CyclopsMC/CyclopsCore#243 and CyclopsMC/CommonCapabilities#50, whose submodule pointers reference this branch until this is merged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf