Skip to content

Add validation parsing to file saving - #79

Open
daanvdk wants to merge 2 commits into
masterfrom
save-file-validation-errors
Open

Add validation parsing to file saving#79
daanvdk wants to merge 2 commits into
masterfrom
save-file-validation-errors

Conversation

@daanvdk

@daanvdk daanvdk commented Jan 31, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@daanvdk
daanvdk requested a review from abzainuddin January 31, 2020 16:24
@codecov-io

codecov-io commented Jan 31, 2020

Copy link
Copy Markdown

Codecov Report

Merging #79 into master will decrease coverage by 0.98%.
The diff coverage is 61.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   94.22%   93.24%   -0.99%     
==========================================
  Files           5        5              
  Lines         589      592       +3     
  Branches      128      127       -1     
==========================================
- Hits          555      552       -3     
- Misses         26       32       +6     
  Partials        8        8
Impacted Files Coverage Δ
src/Store.js 100% <100%> (ø) ⬆️
src/BinderApi.js 93.33% <55.55%> (-6.67%) ⬇️
src/Model.js 89.05% <63.63%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1b2ef...cd63ae0. Read the comment docs.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.24%. Comparing base (ab1b2ef) to head (cd63ae0).
⚠️ Report is 70 commits behind head on master.

Files with missing lines Patch % Lines
src/BinderApi.js 55.55% 4 Missing ⚠️
src/Model.js 63.63% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   94.22%   93.24%   -0.99%     
==========================================
  Files           5        5              
  Lines         589      592       +3     
  Branches      128      127       -1     
==========================================
- Hits          555      552       -3     
- Misses         26       32       +6     
  Partials        8        8              
Files with missing lines Coverage Δ
src/Store.js 100.00% <100.00%> (ø)
src/BinderApi.js 93.33% <55.55%> (-6.67%) ⬇️
src/Model.js 89.05% <63.63%> (-0.58%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab1b2ef...cd63ae0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants