-
Notifications
You must be signed in to change notification settings - Fork 2
refactor(review): drop the /codeboarding refresh and full arguments #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -228,7 +228,7 @@ runs: | |
| run: "$GITHUB_ACTION_PATH/scripts/action/fetch-state.sh" | ||
|
|
||
| - name: Fetch this pull request's last analysis | ||
| if: steps.guard.outputs.skip != 'true' && steps.guard.outputs.mode == 'review' && steps.guard.outputs.seed_mode == 'chain' && steps.state.outputs.warmstart_name != '' && github.server_url == 'https://github.com' | ||
| if: steps.guard.outputs.skip != 'true' && steps.guard.outputs.mode == 'review' && steps.state.outputs.warmstart_name != '' && github.server_url == 'https://github.com' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a PR receives at least one trusted review within every Useful? React with 👍 / 👎. |
||
| continue-on-error: true | ||
| shell: bash | ||
| env: | ||
|
|
@@ -333,7 +333,6 @@ runs: | |
| REVIEW_HEAD_SHA: ${{ steps.guard.outputs.head_sha }} | ||
| REVIEW_BASE_REPO: ${{ steps.guard.outputs.base_repo }} | ||
| PR_NUMBER: ${{ steps.guard.outputs.pr_number }} | ||
| SEED_MODE: ${{ steps.guard.outputs.seed_mode }} | ||
| BASE_DIR: ${{ runner.temp }}/cb-state/${{ github.action }}/base | ||
| WARMSTART_DIR: ${{ runner.temp }}/cb-state/${{ github.action }}/warmstart | ||
| RENEW_BASE: ${{ steps.fetch_base.outputs.renew }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes the documented semantics of
/codeboarding refreshand/codeboarding full: existing users invoking them specifically to bypass warm-start state or force a rebuild will now silently receive an ordinary incremental review. The commit is labeledrefactor(review)without a breaking marker, so this change can ride into the moving current-major tag instead of preserving the old behavior for current-major consumers; classify it with!or aBREAKING CHANGE:footer so release-please creates the required major release.AGENTS.md reference: AGENTS.md:L57-L60
Useful? React with 👍 / 👎.