Conversation
🦋 Changeset detectedLatest commit: e8bb109 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-lowvjhiyk-clickhouse.vercel.app Built from commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harden how
CardHorizontalandCardPrimaryopeninfoUrl.infoUrlwithnoopener, so the new page can no longer reach back into the app throughwindow.opener(reverse tabnabbing). Browsers add this for<a target="_blank">but not forwindow.open.Links and tickets
infoUrlvalues silently and coveredCardHorizontalonly.Checklist
Contribution
buildandbuild-storybookwork locallyAccessibility
Skipped: no markup, focus, keyboard or style change. Only what happens after a click changed.
Screenshots
No visual change.