Conversation
Tooltip.Trigger now renders a button by default so content is available on keyboard focus. Wrapping Button, IconButton, or a link without asChild nests interactive elements and is a potentially breaking change. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: f1f3180 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook Preview Deployed✅ Preview URL: https://click-j2lyi1y07-clickhouse.vercel.app Built from commit: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dff6571. Configure here.
Read calendar weekday headers from both weekDays and weekdays so the DatePicker typechecks on @h6s/calendar 2.2.0. Restore card aria-disabled for disabled styles without putting wrappers back in the tab order, and update visual tests to the new keyboard model. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Hi — I maintain RunBack, an early-alpha CLI that takes a failed GitHub Actions run URL and tries to reproduce that exact failure locally. I preregistered the earlier If you are willing to try curl -fsSL https://raw.githubusercontent.com/huanglinfei091-cmd/runback/main/scripts/install-release.sh | bash
~/.local/bin/runback doctor
~/.local/bin/runback <failed-run-url>A failed reproduction or install problem is useful feedback too. Please do not share tokens, secrets, cookies, or private logs. No follow-up is needed if this is not useful for your workflow. |
|
See here: Recommendation is to approach this as a second stage of updates after stabilization of changes in #1189 . |

Why?
Follow-up to the ARIA labelling work. Several Click UI controls were mouse-only or injected extra tab stops, which fails WCAG 2.2 AA for consuming apps (2.1.1, 2.4.3, 1.4.13).
Summary
weekDays)Potentially breaking:
Tooltip.TriggerTooltip.Triggernow renders a<button type="button">by default, not adiv.That is so tooltip content is available on keyboard focus, not hover only (WCAG 1.4.13).
If you wrap an existing interactive element (
Button,IconButton,Link,<a>, or<button>), you must passasChild. Without it you get a nested button: invalid HTML and a worse accessible name.Plain text or other non-interactive children do not need
asChild.EllipsisContentalready usesasChild.Test plan
Tooltip.Trigger(text): tooltip opens on focus.Tooltip.TriggerwrappingButton/IconButtonand addasChild.Made with Cursor