feat: add Studio Sound microphone enhancement - #2283
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Studio Sound to the Sound tab in both editors, with a shared default for new Studio recordings. It reduces microphone noise during playback and export, preserves original media and source timing, and leaves system audio and music unchanged. Live toggles retain the video engine and transport controls; export processes bounded source windows.
Validation: six processor tests, 20-variant sample-exact playback/export parity, microphone/system isolation, live PCM refresh, stale-generation cancellation, and macOS segmented-video handoff with the original seek/stop handle. Tauri and GPUI cargo checks, desktop TypeScript and scoped Biome passed. A complete 2h24m recording streamed successfully with the effect off/on; an isolated release processor measured about 1.2% of one CPU core in real time and 2.5 MB peak RSS.
Interactive GUI/device timing and native Windows/Linux playback remain unverified. Scoped Clippy reported no diagnostics in changed files; strict Rust 1.95 Clippy is blocked by existing warnings in audio latency/progressive code.
The PR appears safe to merge; the prior live-refresh positioning concern is resolved and no new actionable failures remain.
Summary
Reviews (2) · Last reviewed commit: "fix: preserve audio position when toggli..."