Skip to content

feat: add Studio Sound microphone enhancement - #2283

Merged
richiemcilroy merged 2 commits into
mainfrom
feature/studio-voice-enhancement
Sep 12, 2026
Merged

feat: add Studio Sound microphone enhancement#2283
richiemcilroy merged 2 commits into
mainfrom
feature/studio-voice-enhancement

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Sep 12, 2026

Copy link
Copy Markdown
Member

Adds Studio Sound to the Sound tab in both editors, with a shared default for new Studio recordings. It reduces microphone noise during playback and export, preserves original media and source timing, and leaves system audio and music unchanged. Live toggles retain the video engine and transport controls; export processes bounded source windows.

Validation: six processor tests, 20-variant sample-exact playback/export parity, microphone/system isolation, live PCM refresh, stale-generation cancellation, and macOS segmented-video handoff with the original seek/stop handle. Tauri and GPUI cargo checks, desktop TypeScript and scoped Biome passed. A complete 2h24m recording streamed successfully with the effect off/on; an isolated release processor measured about 1.2% of one CPU core in real time and 2.5 MB peak RSS.

Interactive GUI/device timing and native Windows/Linux playback remain unverified. Scoped Clippy reported no diagnostics in changed files; strict Rust 1.95 Clippy is blocked by existing warnings in audio latency/progressive code.

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the prior live-refresh positioning concern is resolved and no new actionable failures remain.

Summary

  • Introduces bounded RNNoise-based microphone processing while leaving system audio and music unchanged.
  • Integrates enhancement into preview, playback refresh, variable-speed rendering, and export.
  • Adds Studio Sound controls and shared defaults to the Tauri and GPUI clients.
  • Realigns replacement audio during live toggles and rejects stale refresh work.
  • Adds processor, playback, export-parity, isolation, cancellation, and segmented-video tests.

Reviews (2) · Last reviewed commit: "fix: preserve audio position when toggli..."

@socket-security

socket-security Bot commented Sep 12, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcargo/​nnnoiseless@​0.5.2100100100100100

View full report

Comment thread crates/editor/src/playback.rs
@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy
richiemcilroy merged commit 8408d2d into main Sep 12, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant