improve: keep camera previews smooth across window transitions - #2282
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Member
Author
|
hey @greptileai, please re-review the PR |
![superagent-security[bot]](https://avatars.githubusercontent.com/in/3287076?s=60&v=4){kind=small}
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening the desktop controls currently clears the camera preview while capture restarts. Retain the previous same-camera frame and fade it out over the first live frames in the default Tauri preview and GPUI, preserving the preview dimensions across reopen.
Capture still stops when the preview is unused. Cached frames expire after 60 seconds and are invalidated for camera changes or errors; macOS GPUI copies a single snapshot capped at 960×540 rather than holding a camera surface. Cached pixels do not satisfy recording readiness.
Validation: scoped Biome and Rust formatting, isolated GPUI cargo check, 7 Tauri route transition tests with mocked transport, 8 existing frame-transport tests, and 5 native snapshot and capture-timestamp tests passed. Three real MacBook camera lifecycle cycles completed using the existing harness; this change masks restart latency and makes no capture-speedup claim.
Packaged UI, Windows, and Linux runtime verification remain outstanding. The experimental native Tauri renderer is unchanged. A broader Clippy check reports 19 existing diagnostics outside the changed files.
The current changes appear safe to merge, with no actionable new defects or outstanding previous findings identified.
Summary
Reviews (3) · Last reviewed commit: "fix: confirm camera snapshot copies befo..."