fix: polish GPUI editor corners and editing controls - #2281
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPUI editor could paint waveforms and other timeline fills through rounded clip corners, and the sidebar tab strip covered its card corners. Keep those layers inside the rounded shape and paint the segment border last.
Make Split visible with a label, an active state, a scissors cut guide across segment tracks, and Escape to finish. Give automatic zoom generation a solid theme-aware button with a disabled loading state.
Validation: the isolated GPUI app and simulated merge with current main compile without warnings; waveform tessellation passes 64 clip-width, viewport and gain cases; rounded fade/hold construction, 25 split-preview boundary cases, the GPUI test-target typecheck, and scoped formatting pass. Five pre-existing Clippy findings remain outside the changed sections. Native appearance and interaction have not been tested; the shared desktop runtime is occupied by camera validation. Windows/Linux runtime validation is also pending.
The PR appears safe to merge, with the previously reported split-guide edge mismatch resolved.
Summary
Reviews (2) · Last reviewed commit: "fix: align split previews with valid cut..."