Skip to content

fix: restore recorded cursor behavior in both editors - #2279

Merged
richiemcilroy merged 1 commit into
mainfrom
fix/editor-cursor-behavior
Sep 12, 2026
Merged

fix: restore recorded cursor behavior in both editors#2279
richiemcilroy merged 1 commit into
mainfrom
fix/editor-cursor-behavior

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Sep 12, 2026

Copy link
Copy Markdown
Member

Selecting macOS, macOS Tahoe, or Windows turned recorded cursors with missing shape metadata into arrows. Restore their captured image fallback and add a separate Default option in both the regular and GPUI editors, with descriptions explaining each appearance.

Recognize the newer Tahoe pointing/open/closed hand cursors when recording and recover their SVG assets from existing recordings using exact decoded-pixel fingerprints. Custom images remain intact, and saved recordings need no migration.

Validation: both renderer and GPUI compile checks, desktop TypeScript and Biome, 10 cursor-info tests, 274 renderer tests (5 existing ignored), 2 picker tests, 3 GPUI selection tests in an isolated source harness, Metal cursor-edge regression, and scoped Clippy passed. The actual Solid picker also bundles successfully. Native cursor fingerprints were checked on macOS; installed-editor visual testing and Windows/Linux runtime testing remain outstanding. Browser preview of the isolated local file was blocked by the browser URL policy.

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the two editors aligned and recorded/custom cursor fallback preserved through the shared renderer.

Summary

  • Preserves custom and metadata-less recorded cursor images instead of replacing them with platform arrows.
  • Recognizes current Tahoe hand cursors and recovers scalable assets for three known legacy pixel fingerprints.
  • Adds aligned Default selection, ordering, descriptions, and compatibility handling for legacy Pointer projects across the Solid and GPUI editors.
  • Adds focused tests for selection behavior, family mapping, and recovered cursor assets.

Reviews (1) · Last reviewed commit: "fix: restore recorded cursor behavior in..."

@richiemcilroy

Copy link
Copy Markdown
Member Author

hey @greptileai, please re-review the PR

@richiemcilroy
richiemcilroy merged commit c59c2b8 into main Sep 12, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant