fix: restore recorded cursor behavior in both editors - #2279
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting macOS, macOS Tahoe, or Windows turned recorded cursors with missing shape metadata into arrows. Restore their captured image fallback and add a separate Default option in both the regular and GPUI editors, with descriptions explaining each appearance.
Recognize the newer Tahoe pointing/open/closed hand cursors when recording and recover their SVG assets from existing recordings using exact decoded-pixel fingerprints. Custom images remain intact, and saved recordings need no migration.
Validation: both renderer and GPUI compile checks, desktop TypeScript and Biome, 10 cursor-info tests, 274 renderer tests (5 existing ignored), 2 picker tests, 3 GPUI selection tests in an isolated source harness, Metal cursor-edge regression, and scoped Clippy passed. The actual Solid picker also bundles successfully. Native cursor fingerprints were checked on macOS; installed-editor visual testing and Windows/Linux runtime testing remain outstanding. Browser preview of the isolated local file was blocked by the browser URL policy.
The PR appears safe to merge, with the two editors aligned and recorded/custom cursor fallback preserved through the shared renderer.
Summary
Reviews (1) · Last reviewed commit: "fix: restore recorded cursor behavior in..."