fix: harden Loops delivery monitoring and cutover sync - #2276
Merged
Conversation
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
Member
Author
|
hey @greptileai, please re-review the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live migration test found that Loops rejects audience-filter edits while a workflow is Sending. The monitor now reports
manual-pause-requiredand explicitly says delivery has not stopped. It re-reads status if a workflow starts during an attempted update, without relying on the provider’s error wording. Draft and paused workflows retain the existing guarded hold behavior.Changing the enrollment switch or a future cutoff previously invalidated every historical profile’s sync fingerprint. Fingerprints now use each contact’s effective signup and teammate-join eligibility, keeping historical accounts stable while preserving updates when an account crosses the cutoff or enrollment is disabled.
The runbook and Action step describe the actual API limitation. Automatic stopping remains unresolved; lifecycle activation requires a supported automatic control or an approved manual-response plan.
Validation: 62 focused profile, lifecycle and safety tests pass, along with scoped Biome and
git diff --check. The live owned-inbox test reproduced HTTP 400 with a contact queued in a timer. The corrected monitor reported the required manual pause against a real Sending workflow without changing its revision. That workflow was manually paused and held, and its two owned contacts unsubscribed. Customer workflows remain Draft and held.The PR appears safe to merge; no outstanding correctness, security, or repository-rule violations were identified.
Summary
Reviews (4) · Last reviewed commit: "fix: keep historical Loops profiles stab..."