Update release.yaml - #48
Merged
Merged
Conversation
Coverage Report for CI Build 32961381980Coverage remained the same at 78.854%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
harryswift01
previously approved these changes
Aug 26, 2026
harryswift01
left a comment
harryswift01
left a comment
Member
There was a problem hiding this comment.
This looks like a safe way to notify Zulip when we mint a new software release. Everything looks to be in place correctly, and I particularly like having the safety net of continue-on-error so a notification failure won't block the release workflow. I'm happy to see this merged in. Thanks for adding this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed the zulip-notification.yaml because the default GitHub token will not allow the workflow to trigger a second workflow.
Also set continue in error in the notification workflow to prevent termination of release workflow further steps for a failed notify.
Impact
The notification should now fire since it is part of the release cycle itself.