Manage match outcome reasons and filter APIs (#141: part 2) - #202
Open
tanman1049 wants to merge 7 commits into
Open
Manage match outcome reasons and filter APIs (#141: part 2)#202tanman1049 wants to merge 7 commits into
tanman1049 wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the admin-managed, per-competition outcome-reason catalog and exposes the public APIs required for match-history filtering.
Related to #141. Builds on #187, which added storage for map codes and raw outcome-reason codes.
Catalog and admin management
game_match_outcome_reasonscatalog table.timeoutandcode_errorfor existing and newly created competitions.(competition, code)pairs.Public match-history API
GET /api/v1/public/game-match/filter-options.mapCode,outcomeReasonCode, andunregisteredOutcomeReasonfilters to public match-history search.Behavior
Unregistered outcome codes do not block finalization, win/loss processing, or Glicko updates. They remain queryable through Other.
Tests
Adds unit coverage for catalog management and filter-option construction, plus integration coverage for map, named-reason, and Other filters.