GAUD-10602 - Enhance drag command so the consumer can pick whether the drag is completed - #1089
Merged
Merged
Conversation
svanherk
commented
Sep 17, 2026
| if (shouldResetMouse) { | ||
| shouldResetMouse = false; | ||
| await sendMouse({ type: 'move', position: [0, 0] }).catch(() => {}); | ||
| await sendMouse({ type: 'move', position: [0, 0] }); |
Contributor
Author
There was a problem hiding this comment.
From what I can tell, the catch here was added for manual mode. We have removed that mode, and I didn't see any issues when using open.
svanherk
commented
Sep 17, 2026
| @@ -74,7 +74,8 @@ export async function reset(opts = {}) { | |||
|
|
|||
| if (shouldResetMouse) { | |||
Contributor
Author
There was a problem hiding this comment.
web-test-runner has a resetMouse command that ideally we would be using. But it doesn't work in --open mode for Chrome at all, because the reset opens up the context menu. Issue is here, and more info in this comment.
svanherk
marked this pull request as ready for review
September 17, 2026 15:07
|
🎉 This PR is included in version 1.53.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
vdiffsto see the state of closing or opening a panel by dragging