BUG: Fixed stack-use-after-return asan issue with ReadStlFileTest - #1711
Draft
JDuffeyBQ wants to merge 1 commit into
Draft
BUG: Fixed stack-use-after-return asan issue with ReadStlFileTest#1711JDuffeyBQ wants to merge 1 commit into
JDuffeyBQ wants to merge 1 commit into
Conversation
* `GENERATE_COPY` deduced the variables as `const std::string&` instead of `std::string` which caused a lifetime issue * For future reference other solutions that would also work here: * Making the constants `static` * Avoiding variables entirely and using string literals directly Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GENERATE_COPYdeduced the variables asconst std::string&instead ofstd::stringwhich caused a lifetime issuestatic