ENH: Changed test macros to copy result - #1709
Draft
JDuffeyBQ wants to merge 1 commit into
Draft
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
JDuffeyBQ
force-pushed
the
topic/test_macro_enh
branch
from
August 21, 2026 15:26
886296b to
e38ad27
Compare
- Wrapped inside do while block for formatting - Now check that the argument to the macros is actually a Result Signed-off-by: Jared Duffey <jared.duffey@bluequartz.net>
JDuffeyBQ
force-pushed
the
topic/test_macro_enh
branch
from
August 21, 2026 20:16
e38ad27 to
ce4ba55
Compare
Collaborator
Author
|
After thinking about this change, one issue with this method is that it makes the error message when a Because of that it might be better to just add a compile time check that only allows lvalues to prevent the macro expansion from running the expression multiple times. I've tested a version that does that locally now and there are currently only 3 locations that fail. All of which are quick fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1704
SIMPLNX_RESULT_REQUIRE_VALIDandSIMPLNX_RESULT_REQUIRE_INVALIDnow assign the inputResult<T>to avoid macro duplication when the argument is an expression (may copy or move depending on input type).For tests, I think the following typical form should still be preferred since it allows for easy access to the
Resultin the debugger. This PR mainly serves as a guard against unintended behavior.