fix: fix pruning not using max sharing - #379
Open
stringhandler wants to merge 2 commits into
Open
Conversation
Collaborator
|
Can you run |
stringhandler
force-pushed
the
st-fix-pruning-twins
branch
from
August 25, 2026 14:35
4c7be1b to
eb80a3d
Compare
Contributor
Author
|
done. |
Collaborator
|
Can you also split the unit test into a separate commit (fix first, then test, so that all commits pass, but locally I'll delete the fix to see if the test fails)? |
Adds a unit test that replicates BlockstreamResearch/SimplicityHL#391
stringhandler
force-pushed
the
st-fix-pruning-twins
branch
from
August 25, 2026 14:40
eb80a3d to
35a4913
Compare
Contributor
Author
|
done. |
Collaborator
|
Nice, thanks! Okay, this is definitely a bug (I wasn't sure it was possible to construct an unshared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for BlockstreamResearch/SimplicityHL#391
As described in the issue, there are cases when a pruned program still contains some unpruned nodes.
The test included fails when the pruning uses Internal sharing rather than MaxSharing.