fix(key-card): carry VRF material through safe recovery - #9718
Draft
s84krish wants to merge 1 commit into
Draft
Conversation
Parse the versioned safe MPC envelope alongside legacy reduced shares, and return both signing and VRF material to recovery callers. Keep safe keycard boxes on the existing layout while documenting and testing the VRF-bearing payload and its QR fragmentation. This prevents safe recovery from treating the versioned envelope as a bare ReducedKeyShare, which would discard the VRF material required for child re-derivation. Ticket: WCN-2325 Session-Id: b5978d12-c20a-4c72-b9d0-b66a56204cd0 Task-Id: 7f111b0b-938f-4512-9dab-397624fe5f74
ralph-bitgo
Bot
force-pushed
the
WCN-2325-keycard-vrf
branch
from
September 10, 2026 21:16
020accb to
bb3d7d6
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Safe MPC roots now carry VRF material in the versioned reduced envelope. Treating that ciphertext as a bare ReducedKeyShare drops the VRF share and makes safe child re-derivation impossible.
Recovery conclusion
A bare 32-byte VRF scalar is not sufficient for the current VRF wasm API:
VrfKeyshareis restored from its complete serialized keyshare, which includes public metadata. This change therefore carries the serialized VRF keyshare in the envelope and exposes it to recovery. The recovery wizard currently supports traditional wallet recovery, not safe MPC child derivation. Full safe recovery still needs the interactive BitGo derive ceremony, safe child metadata/index handling, VRF/DKLS derive orchestration, and wizard UI/IPC integration before it can be offered.Verification
Ticket: WCN-2325