fix(abstract-eth): preserve zero wallet version for CCR - #9698
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
fix(abstract-eth): preserve zero wallet version for CCR#9698ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Treat walletVersion zero as an explicitly provided version when signing cross-chain recovery transactions. Add CCR coverage for zero-version build responses across hot, cold, and build flows.\n\nTicket: SPT-443 Session-Id: 2d0de46e-8f1d-405d-9e29-f0876c51a7eb Task-Id: 4d50ea0c-454c-4c73-8c1f-87991bb25769
ralph-bitgo
Bot
force-pushed
the
SPT-443-self-serve-ccr-recoveryid
branch
from
September 9, 2026 11:41
012e197 to
692c4d8
Compare
Contributor
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
walletVersion: 0while signing EVM cross-chain recovery transactions.Why
Legacy version-zero wallets were treated as if no wallet version had been supplied, so self-serve CCR signing could construct an invalid transaction.
Verification
git diff --checkpassed.nix develop . --command yarn workspace @bitgo/sdk-coin-ethlike unit-test --grep "cross chain recovery".mochais unavailable (node_modulesdependencies are not installed).Ticket: SPT-443